preloaded module missing cookies.

[tengmaoqing]

Clear and concise description of the problem

The preloaded module may missing cookies in some browser. (For example：windows QQ browser 10.8 4405 chromium70.0.3538.25).

Reproduction

• download the QQ browser (windows)
• open https://tengmaoqing.github.io/vite-cookies-demo/dist/. and get pic1
• open https://tengmaoqing.github.io/vite-cookies-demo/dist/c-index.html. get pic2

pic1

the request header without cookies in file that name is vendor.9ed1d783.js.

pic2

This request carries a cookie in file that name is vendor.9ed1d783.js when i added crossorigin.

Suggested solution

Added the crossorigin attribute to the modulepreload link tag
#4408

Alternative

No response

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

[haoqunjiang]

The issue is an old Chrome bug.
https://bugs.chromium.org/p/chromium/issues/detail?id=849101

[haoqunjiang]

I don't think Vite should add the crossorigin attribute by default just to work around the Chrome bug.

But we can add the crossorigin attribute to modulepreload tags if there's a crossorigin attribute on the entry script tag.

[tengmaoqing]

there's a crossorigin attribute on the entry script tag

em. Vite added the crossorigin attribute by default on the entry script tag. But modulepreload didn’t.

This causes the problem.

[sapphi-red]

Looks like this commit introduced that change.
e6f7fba#diff-89bae1df62862bb7f4a03d82a1e9cbf4ac6d0c042f21fbbacb0a2238bd050042R285

[bluwy]

Closing as #4408 is merged