Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-app): update svelte-ts template to use @tsconfig/svelte a… #3668

Merged
merged 1 commit into from
Jun 3, 2021

Conversation

dominikg
Copy link
Contributor

@dominikg dominikg commented Jun 3, 2021

…nd svelte-check

Description

follow the official svelte ts template and use @tsconfig/svelte + svelte-check

sveltejs/template@f92a0a4
https://github.com/tsconfig/bases/blob/master/bases/svelte.json

Additional context

should some of the remaining compilerOptions be moved to the base or removed entirely?
cc @dummdidumm @GrygrFlzr


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@antfu antfu merged commit 5c3b668 into vitejs:main Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants