fix(plugin-legacy): Remove and record polyfills in plugin post (fix #2786, #2781)

[TobiasMelen]

Makes sure all polyfill ES imports are trimmed from legacy bundle by moving recording and removal from Program:exit to post in plugin. This seems to ensure that @babel/preset-env has found and added all polyfills from all nodes in chunk before recordAndRemovePolyfillBabelPlugin processes.

Fixes #2786 and #2781.

Additional context

I have not been able to create a test case for this. It's probably an api triggering usage polyfill import in a certain AST structure that causes the bug, but figuring out which seems hard. Instead the solution is tested by users experiencing the bug.

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[FrankFan]

anyone please review this PR, a project of my company need this bugfix urgently.
I'm here waiting for a new release. 👏

the same issue: legacy.278fab9b.js:1 Uncaught SyntaxError: Unexpected token import with chrome 55

[TobiasMelen]

@FrankFan (and others having the issue) It's very possible to workaround this issue until merged and released by using a local version of the plugin:

• Copy all code from https://github.com/vitejs/vite/blob/097d9fef8e27843e245836eb5f89885bcba4b2ec/packages/plugin-legacy/index.js
• Save to local file in your project (eg. ./vite.plugin-legacy.patch.js).
• Import the plugin from that file instead of @vite/plugin-legacy in your vite.config.js. (eg. import pluginLegacy from "./vite.plugin-legacy.patch";)
  I'm happy to see this PR properly reviewed since I have little experience of Babel plugins.

[Shinigami92]

Another way would be to use https://www.npmjs.com/package/patch-package

[patak-dev]

@TobiasMelen would you merge main to this PR? We changed the CI configs and it should pass after re-running. Thanks!

[TobiasMelen]

Ok. I made a rebase mess, but think it's in correct state now.

[marialovesbeans]

Any update on this? Can we have this PR merged?

[yjwSurCode]

@FrankFan (and others having the issue) It's very possible to workaround this issue until merged and released by using a local version of the plugin:

• Copy all code from https://github.com/vitejs/vite/blob/097d9fef8e27843e245836eb5f89885bcba4b2ec/packages/plugin-legacy/index.js
• Save to local file in your project (eg. ./vite.plugin-legacy.patch.js).
• Import the plugin from that file instead of @vite/plugin-legacy in your vite.config.js. (eg. import pluginLegacy from "./vite.plugin-legacy.patch";)
  I'm happy to see this PR properly reviewed since I have little experience of Babel plugins.

不生效 dev环境下 import还是报错
Import still reports an error when it does not take effect in dev environment

[patak-dev]

@yjwSurCode please open a new issue if there is still something that should be fixed in core

[yjwSurCode]

@yjwSurCode please open a new issue if there is still something that should be fixed in core
can you help me? asnyc Import still reports an error when it does not take effect in dev environment about vite.plugin-legacy

[yjwSurCode]

@yjwSurCode please open a new issue if there is still something that should be fixed in core

@patak-js
can you help me? asnyc Import still reports an error when it does not take effect in dev environment about vite.plugin-legacy

[patak-dev]

@yjwSurCode please use GitHub Discussions or join the chat at Vite Land to ask questions.

[yjwSurCode]

@patak-js ok

[yjwSurCode]

@yjwSurCode please use GitHub Discussions or join the chat at Vite Land to ask questions.

Why not answer？

[Shinigami92]

@yjwSurCode Because we don't really track closed/merged issues/prs