feat: add extensions option to vue-jsx plugin #1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's better to follow the convention of Rollup plugins and use |
Emm.... I think include/exclude is another approach, extensions and include/exclude may work together, something like: extensions: ['.jsx', '.tsx', '.mdx'],
include: ['src']instead of include: ['src/**/*.jsx', 'src/**/*.tsx', 'src/**/*.mdx'] |
Jokcy
force-pushed
the
vue-jsx-extensions
branch
from
079b446
to
658de66
Compare
|
@yyx990803 I updated the PR to use rollup plugin utils, please review it. |
antfu
requested changes
Mar 8, 2021
antfu
approved these changes
Mar 15, 2021
antfu
added
the
p2-nice-to-have
|
So when to publish it? |
patak-dev
approved these changes
Apr 19, 2021
TobiasMelen
pushed a commit
to TobiasMelen/vite
that referenced
this pull request
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add extensions option to vue-jsx plugin, so that some other plugin just need to output jsx to reuse vue-jsx plugin ability.
For example, I want to implement mdx plugin for vite, since mdx just compile markdown into jsx, I only need to do some vue3 related coding and leave jsx and hmr to vue-jsx plugin.