Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too long error messages get cropped #17632

Closed
7 tasks done
paulwer opened this issue Jul 8, 2024 · 5 comments · Fixed by #17729
Closed
7 tasks done

Too long error messages get cropped #17632

paulwer opened this issue Jul 8, 2024 · 5 comments · Fixed by #17729
Labels
contribution welcome p2-edge-case Bug, but has workaround or limited in scope (priority)

Comments

@paulwer
Copy link

paulwer commented Jul 8, 2024

Describe the bug

Hi, we encountered a error message while performing optimizeDeps feature.
Here was an error and vite listed all files of the repo. The messages contained informations what failed at the end, but the end was cropped by this feature.

Because of the crop feature we are not able to read the error.

Reproduction

no reproduction url

Steps to reproduce

No response

System Info

System:
    OS: Windows 11 10.0.22621
    CPU: (12) x64 12th Gen Intel(R) Core(TM) i7-1255U
    Memory: 1.11 GB / 15.64 GB
  Binaries:
    Node: 18.19.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.2.3 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.14.0 - C:\Program Files\nodejs\pnpm.CMD
  Browsers:
    Edge: Spartan (44.22621.1555.0), Chromium (126.0.2592.68)
    Internet Explorer: 11.0.22621.1

Used Package Manager

npm

Logs

Error: Failed to scan for dependencies from entries:

...and x more lines

Validations

Copy link

Hello @paulwer. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with needs reproduction will be closed if they have no activity within 3 days.

@paulwer
Copy link
Author

paulwer commented Jul 15, 2024

Not possible, because this would be a big repo, with 1000s files. The edge case is described sufficient.

@bluwy
Copy link
Member

bluwy commented Jul 15, 2024

Do you mean #16581?

The bug that caused it seems to be fixed upstream at alexeyraspopov/picocolors#64, so maybe we can revert our fix here.

@paulwer
Copy link
Author

paulwer commented Jul 15, 2024

yes, thats the part of the logger resulting in this behavior.

@bluwy
Copy link
Member

bluwy commented Jul 16, 2024

I think it wasn't clear what the truncation look like in the logs given, and the logs section was easily missed in the description. Hence a repro would be helpful for others not familiar with this behaviour.

Anyways, with the issue pinpointed, feel free for anyone to fix this.

@bluwy bluwy added contribution welcome p2-edge-case Bug, but has workaround or limited in scope (priority) and removed needs reproduction labels Jul 16, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
contribution welcome p2-edge-case Bug, but has workaround or limited in scope (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants