Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(qwik template): change preview script #15975

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

gioboa
Copy link
Contributor

@gioboa gioboa commented Feb 20, 2024

Description

Qwik use custom plugin qwikVite on top of Vite but with Qwik SPA configuration

qwikVite({ csr: true, })

the preview script fails because qwikVite is not optimized for this config.
With this PR we can have a temporary workaround.

Fixed QwikDev/qwik#4880

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Feb 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

The same change should be applied to template-qwik-ts, no?

@gioboa
Copy link
Contributor Author

gioboa commented Feb 20, 2024

The same change should be applied to template-qwik-ts, no?

Yep, you are right. I'll do it

@patak-dev patak-dev merged commit 725589a into vitejs:main Feb 20, 2024
10 checks passed
@gioboa gioboa deleted the patch-1 branch February 26, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] vite preview fails with vite template starters
3 participants