Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(create-vite): remove non-standard style #14451

Merged
merged 2 commits into from
Sep 25, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Sep 23, 2023

Description

-webkit-text-size-adjust is a non-standard style, after the initialization project runs, a warning message appears.
So I think it should be removed and let users add to specific environments on their own.

image

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@btea btea changed the title fix(create-vite): remmove non-standard style fix(create-vite): remove non-standard style Sep 23, 2023
@btea btea force-pushed the fix/remove-non-standard-style branch from 536f7f4 to 8ba95e1 Compare September 23, 2023 04:11
@ArnaudBarre
Copy link
Member

The warning comes from the Chrome console?

This CSS property feels very too specific for a starter template anyway

@btea
Copy link
Collaborator Author

btea commented Sep 24, 2023

The warning comes from the Chrome console?

The Edge.

@bluwy bluwy merged commit 8349d4e into vitejs:main Sep 25, 2023
10 checks passed
@btea btea deleted the fix/remove-non-standard-style branch September 25, 2023 03:20
bluwy added a commit to bluwy/create-vite-extra that referenced this pull request Nov 15, 2023
konrad-jamrozik added a commit to konrad-jamrozik/game that referenced this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants