Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(create-vite): update create vite for Svelte 4 #13602

Merged
merged 4 commits into from
Jun 23, 2023
Merged

feat(create-vite): update create vite for Svelte 4 #13602

merged 4 commits into from
Jun 23, 2023

Conversation

roberto-butti
Copy link
Contributor

Description

Upgrading the Svelte template to Svelte 4

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jun 22, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@roberto-butti roberto-butti changed the title Update create vite for Svelte 4 build: Update create vite for Svelte 4 Jun 22, 2023
@roberto-butti roberto-butti changed the title build: Update create vite for Svelte 4 build: update create vite for Svelte 4 Jun 22, 2023
bluwy
bluwy reviewed Jun 23, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also help bump @sveltejs/vite-plugin-svelte to 2.4.2? That version updates the peer dep ranges to include Svelte 4.

bluwy
bluwy approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks!

@bluwy bluwy changed the title build: update create vite for Svelte 4 feat(create-vite): update create vite for Svelte 4 Jun 23, 2023
@bluwy bluwy merged commit 8868fb7 into vitejs:main Jun 23, 2023
14 checks passed
xinxinhe1810 pushed a commit to xinxinhe1810/vite that referenced this pull request Jul 4, 2023
@roberto-butti @xinxinhe1810
feat(create-vite): update create vite for Svelte 4 (vitejs#13602)
ddb0111
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@roberto-butti @bluwy