Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'module' is not defined eslint error in template-react (fix #13517) #13518

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

w3cj
Copy link
Contributor

@w3cj w3cj commented Jun 14, 2023

Description

Fixes #13517

This adds the node env to the .eslintrc.cjs file in packages/create-vite/template-react and packages/create-vite/template-react-ts templates to fix the linter error 'module' is not defined

There are a few other ways to fix this, but I think this way makes the most sense and does not affect the linting of other files in the project.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Jun 14, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@w3cj w3cj changed the title fix #13517: 'module' is not defined eslint error in template-react fix: 'module' is not defined eslint error in template-react (fix #13517) Jun 14, 2023
@vitejs vitejs deleted a comment from w3cj Jun 18, 2023
@patak-dev patak-dev merged commit 41380a5 into vitejs:main Jun 19, 2023
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'module' is not defined eslint error in template-react
3 participants