fix(icon): template-vanilla add favicon.ico #1340

linbingquan · 2021-01-04T07:44:23Z

Bug report:

Use template: vanilla js.
Run yarn and yarn build.
Something warn in terminal like this.

PS D:\MyProjects\vite-helloworld> yarn build
yarn run v1.22.10
warning package.json: No license field
$ vite build
building for production...
[vite:build-html] ENOENT: no such file or directory, open 'D:\MyProjects\vite-helloworld\favicon.ico'
file: /MyProjects/vite-helloworld/index.html
error during build:
Error: ENOENT: no such file or directory, open 'D:\MyProjects\vite-helloworld\favicon.ico'
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

yyx990803 · 2021-01-04T07:57:48Z

Thanks, I think it's better to just remove it.

linbingquan · 2021-01-04T08:08:14Z

Thank you for your reply. Is this what you want. Should I make a PR to fix it.

diff --git a/packages/create-app/template-vanilla/index.html b/packages/create-app/template-vanilla/index.html
index e4f0209..60fd73f 100644
--- a/packages/create-app/template-vanilla/index.html
+++ b/packages/create-app/template-vanilla/index.html
@@ -2,7 +2,6 @@
 <html lang="en">
 <head>
   <meta charset="UTF-8">
-  <link rel="icon" href="/favicon.ico" />
   <meta name="viewport" content="width=device-width, initial-scale=1.0">
   <title>Vite App</title>
 </head>

fix(icon): template-vanilla add favicon.ico

a9f59a6

yyx990803 closed this in d9df7eb Jan 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(icon): template-vanilla add favicon.ico #1340

fix(icon): template-vanilla add favicon.ico #1340

linbingquan commented Jan 4, 2021

yyx990803 commented Jan 4, 2021

linbingquan commented Jan 4, 2021 •

edited

Loading

fix(icon): template-vanilla add favicon.ico #1340

fix(icon): template-vanilla add favicon.ico #1340

Conversation

linbingquan commented Jan 4, 2021

yyx990803 commented Jan 4, 2021

linbingquan commented Jan 4, 2021 • edited Loading

linbingquan commented Jan 4, 2021 •

edited

Loading