-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve browser mapping using bare imports (fix #11208) #11219
Conversation
6700910
to
d87d043
Compare
d87d043
to
6e9d1b4
Compare
Hello 😃 |
5161781
to
bff6b06
Compare
Waiting for review 😃. |
Hi @sapphi-red Is there anything I can help to get this minor bug fix merged? Thanks! |
@sapphi-red I'm also looking to get this merged as it's a huge blocker for a project. More than willing to help out! |
This is also a huge blocker for me :) |
What can be done to get this unstuck? This is a big blocker for a lot of people. |
Shall we ask additional reviewers like @bluwy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make some changes, but the idea of the change LGTM 👍 Gonna run the ecosystem-ci later once the tests here passes.
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
Forgot to run ecosystem-ci, thanks for handling it patak 😄 Looks like we're good to go, the failures shown were also failing in main. Might be good to get another review before merging. |
Description
When a dep to be resolved has a browser field mapping to a bare import, Vite doesn't resolve that mapping, which is not as expected.
Fixes #11208
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).