chore: remove duplicated logic in vanilla template

[curran]

Description

When getting started with Vite, I noticed some odd code in the vanilla template:

export function setupCounter(element) {
  let counter = 0              
  const setCounter = (count) => { 
    counter = count            
    element.innerHTML = `count is ${counter}`
  }
  element.addEventListener('click', () => setCounter(++counter))
  setCounter(0)                
} 

The ++counter expression actually mutates counter, but then it is also mutated by counter = count. I find this confusing, and it's not the sort of thing I would expect to see in a template example.

I would suggest to make a small change so that instead of mutating counter twice, it's mutated only once, inside the body of setCounter.

Additional context

---

What is the purpose of this pull request?

• Bug fix
• New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• Read the Contributing Guidelines.
• Read the Pull Request Guidelines and follow the Commit Convention.
• Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[sapphi-red]

Thanks! Would you update this line, too?

vite/packages/create-vite/template-vanilla-ts/src/counter.ts

Line 7 in 53e1234

element.addEventListener('click', () => setCounter(++counter))

[curran]

Will do! Thanks for reviewing.

[curran]

Done. Requesting re-review please @sapphi-red. Thanks!

[patak-dev]

Thanks @curran, good catch!