fix: add @types/node as an optional peer dependency (#10757)

The built bundle of Vite starts with a reference to `node` types: https://unpkg.com/browse/[email protected]/dist/node/index.d.ts This means those who depend on Vite type definitions should install `@types/node` in their projects to successfully do type-checking. In that sense, `@types/node` is an optional peer dependency of Vite. After this being fixed, we should revert vitejs/vite-ecosystem-ci#85 because not explicitly depending on `@types/node` *should* be erroneous. The ecosystem CI shouldn't cover that error for downstream packages.
vitejs · Nov 4, 2022 · 57916a4 · 57916a4
1 parent 1f57f84
commit 57916a4
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/packages/vite/package.json b/packages/vite/package.json
@@ -123,13 +123,17 @@
     "ws": "^8.10.0"
   },
   "peerDependencies": {
+    "@types/node": ">= 14",
     "less": "*",
     "sass": "*",
     "stylus": "*",
     "sugarss": "*",
     "terser": "^5.4.0"
   },
   "peerDependenciesMeta": {
+    "@types/node": {
+      "optional": true
+    },
     "sass": {
       "optional": true
     },