-
-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Set the dependency versions for the "yedit" module. #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitabaks
changed the title
Set the dependency versions for the "yedit" module.
Fix: Set the dependency versions for the "yedit" module.
Dec 13, 2023
Test
Result:
passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #496
New versions of
ruamel.yaml
(0.18.x) are incompatible with the current version of the "yedit" module, which may lead to a PITR error during an attempt to edit thepatroni.yml
orpatroni.dynamic.json
parameter files.We set the dependencies version on earlier versions to avoid errors.
Fixed:
We will monitor the progress of fixing compatibility with more recent versions on the yedit project. If the module is no longer maintained, then perhaps in subsequent releases of postgresql_cluster we will abandon its use.