Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameters for patroni etcd username, password and namespace #473

Merged
merged 10 commits into from
Sep 26, 2023
Merged

Parameters for patroni etcd username, password and namespace #473

merged 10 commits into from
Sep 26, 2023

Conversation

lavr
Copy link
Contributor

@lavr lavr commented Sep 24, 2023

When using a shared etcd cluster, it is necessary to have the ability to configure additional parameters in the patroini config: namespace, login, password, and protocol

@vitabaks
Copy link
Owner

@lavr Hi!

I see that your changes are primarily aimed at working with existing etcd cluster (dcs_exists: true).

It would not be bad to add the ability to configure https and authorization also for a new etcd cluster deployment (dcs_exists: false)

vars/main.yml Outdated Show resolved Hide resolved
@lavr
Copy link
Contributor Author

lavr commented Sep 25, 2023

@lavr Hi!

I see that your changes are primarily aimed at working with existing etcd cluster (dcs_exists: true).

It would not be bad to add the ability to configure https and authorization also for a new etcd cluster deployment (dcs_exists: false)

To add authentication for the etcd cluster deployment, significant updates to the etcd role are required, as I can see.
This includes creating etcd root user with password, enabling authentication, creating a user and role with permissions for patroni cluster in etcd. This will entail substantial work on the etcd role. I can participate in this effort, but I suggest creating a separate Issue for it and handling it independently from this PR.

lavr and others added 2 commits September 25, 2023 16:26
Co-authored-by: Vitaliy Kukharik <[email protected]>
vars/main.yml Outdated Show resolved Hide resolved
vars/main.yml Outdated Show resolved Hide resolved
vars/main.yml Outdated Show resolved Hide resolved
vars/main.yml Outdated Show resolved Hide resolved
Co-authored-by: Vitaliy Kukharik <[email protected]>
@vitabaks vitabaks merged commit de4d400 into vitabaks:master Sep 26, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants