Fix yaml[truthy] from all workflow files #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @vitabaks, I've been giving some thought to the files in the .github directory. Since these files are not part of Ansible, I'm wondering if it might be better to ignore them when running ansible-lint, and just use yamllint instead. What are your thoughts on this? Do you think it would be a good idea, or is there a reason for including these files in ansible-lint that I may have missed? Looking forward to your feedback. |
|
That's right ansible-lint needs to be performed only for playboys and ansible roles. |
vitabaks
reviewed
Jun 10, 2023
.github/workflows/docker.yml
Outdated
| @@ -1,7 +1,7 @@ | |||
| --- | |||
| name: "Docker" | |||
|
|
|||
| on: | |||
| on: # noqa yaml[truthy] | |||
There was a problem hiding this comment.
I suggest removing this comments and simply excluding the .github directory from the ansible-lint checks.
The .github directory is excluded from linting to avoid unnecessary warnings and errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The yaml[truthy] rule was removed from the ansible-lint configuration file, so it is no longer necessary to exclude it from the workflows. This commit removes the yaml[truthy] exclusion from all workflow files.