Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] stylesheet.css not included in npm build #8494

Closed
1 of 7 tasks
chrisgervang opened this issue Feb 13, 2024 · 2 comments · Fixed by #8571
Closed
1 of 7 tasks

[Bug] stylesheet.css not included in npm build #8494

chrisgervang opened this issue Feb 13, 2024 · 2 comments · Fixed by #8571
Assignees
Labels

Comments

@chrisgervang
Copy link
Collaborator

chrisgervang commented Feb 13, 2024

Description

When running yarn build, the widget stylesheet.css isn't coying into the npm dist.
Screen Shot 2024-02-13 at 10 25 23 AM
This causes an file not found import error when running yarn start within the widget example in examples/get-started/pure-js/widgets. Note that yarn start-local works since it it's loading src rather than dist.

On 8.10-release the stylesheet is present.
Screen Shot 2024-02-13 at 12 07 59 PM

Flavors

  • Script tag
  • React
  • Python/Jupyter notebook
  • MapboxOverlay
  • GoogleMapsOverlay
  • CartoLayer
  • ArcGIS

Expected Behavior

stylesheet.css should be copied into dist.

Steps to Reproduce

yarn build on master and inspect the dist.

Environment

  • Framework version: 9
  • Browser: Chrome
  • OS: MacOS

Logs

No response

@chrisgervang chrisgervang changed the title [Bug] stylesheet.css not included in npm bundle [Bug] stylesheet.css not included in npm build Feb 13, 2024
@chrisgervang
Copy link
Collaborator Author

Which build script is responsible? Is it ocular-build? https://github.com/uber-web/ocular/blob/master/modules/dev-tools/scripts/build.sh

Which tool builds deck now? TSC, esbuild, or babel?

@Pessimistress
Copy link
Collaborator

The standard build process does not handle static assets. You should add any copy command to https://github.com/visgl/deck.gl/blob/master/modules/widgets/package.json#L38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants