Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with pointer visibility duration and click delays #10

Closed
virresh opened this issue Apr 11, 2021 · 9 comments
Closed

Fix issues with pointer visibility duration and click delays #10

virresh opened this issue Apr 11, 2021 · 9 comments
Labels
enhancement New feature or request

Comments

@virresh
Copy link
Owner

virresh commented Apr 11, 2021

Point 2 of #8 (comment)
and https://gitter.im/virresh/community?at=60729023ae90f36840733a3d
sums up the issue.

Need to debug and fix timers on posting of runnables.

@4388450
Copy link

4388450 commented Apr 11, 2021

I might suggest that it will be a great idea if you will add a "long press" enable \ disable option in the app and should only be used when needed. Thanks for your work!

@virresh
Copy link
Owner Author

virresh commented Apr 11, 2021

@4388450 thanks for the suggestion
In case the project continues, will keep this in mind.

@4388450
Copy link

4388450 commented Apr 12, 2021

Thanks. Because in the last few hours I had a lot of issues on certain apps because the long click option. So I will really appreciate if you can add a option to disable it

@virresh virresh added the enhancement New feature or request label Jun 20, 2021
@virresh
Copy link
Owner Author

virresh commented Oct 10, 2021

Pointer visibility Long press enable disable fixed by ae5ca99 in the TV version

Closing this issue.

@virresh virresh closed this as completed Oct 10, 2021
@KFMDMSolutions
Copy link

the pointer is visible but it doesn't perform the click until you release the button

@virresh
Copy link
Owner Author

virresh commented Jan 16, 2022

@KFMDMSolutions , do you think it'd be more intuitive if the click is performed as soon as the button is pressed instead of button release?

Any ideas on how to distinguish between a short press and a long press in this case?

@KFMDMSolutions
Copy link

@KFMDMSolutions , do you think it'd be more intuitive if the click is performed as soon as the button is pressed instead of button release?

Any ideas on how to distinguish between a short press and a long press in this case?

lets say i wanna record a 5 min voice message
i have hold the button for 5 min and then speak for 5 min that makes it 10 min to record a 5min message.

it definably needs some delay to differentiate between a short press and a long press
but that doesn't mean we need to wait for the click to complete

@KFMDMSolutions
Copy link

you can start the click after a 2 sec or more delay and stop it onkeyup

@virresh
Copy link
Owner Author

virresh commented Jan 16, 2022

makes sense, although the clicks sent by the gesture API, don't have that kind of leverage.
It needs a gesture made completely before sending and we can't cancel a gesture after it's sent because it's executed immediately.
This makes implementing things like dragging and holding buttons for voice recording impossible.

Android will need to provide something else altogether in order for us to deal with this issue. This functionality exists in Android for sure (they use it with the inbuilt remotes and touchscreens), but haven't exposed the API for use by third-party apps like mine.

What you're describing will become possible with #11
Though probably not implementable at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants