fix(Canvas): Improved behavior when using apple pencil #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed bug: Writing on the drawing board with the iPad pen will lose focus and a selection box will pop up Close vinothpandian#171
ozdevi
reviewed
Sep 5, 2024
| } else { | ||
| x = pointerEvent.pageX; | ||
| y = pointerEvent.pageY; | ||
| } |
There was a problem hiding this comment.
wouldn't be better if it would be like this?:
let { pageX: x, pageY: y } = pointerEvent;
if(pointerEvent instanceof TouchEvent) {
x = pointerEvent.touches[0].pageX;
y = pointerEvent.touches[0].pageY;
}There was a problem hiding this comment.
It will get ts error Property 'pageX' does not exist on type 'TouchEvent | MouseEvent'.ts(2339);
The union type must be determined before it is used
| @@ -69,3 +69,7 @@ export interface CanvasPath { | |||
| */ | |||
| readonly endTimestamp?: number; | |||
| } | |||
|
|
|||
| export interface TouchExtends extends Touch { | |||
| touchType: "direct" | " stylus"; | |||
There was a problem hiding this comment.
" stylus" did you add the whitespace intentionally?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed bug: Writing on the drawing board with the iPad pen will lose focus and a selection box will pop up
Close #171