Fix invalid memory access issue in g++ builds (#228)

* Try to use shared_ptr<CSVField> to avoid memory issues

* Run tests

* Update single include

* Also added test for empty file SEGFAULT

* diD yoU forGet to #incLude<cStrIng>

Author: vincentlaucsb

.github/workflows/cmake-multi-platform.yml

@@ -4,7 +4,7 @@ name: CMake on multiple platforms
 
 on:
   push:
-    branches: [ "master", "gcc-error" ]
+    branches: [ "master", "memory-fix-gcc" ]
   pull_request:
     branches: [ "master" ]
 

include/csv.hpp

@@ -1,5 +1,5 @@
 /*
-CSV for C++, version 2.2.1
+CSV for C++, version 2.2.2
 https://github.com/vincentlaucsb/csv-parser
 
 MIT License

include/internal/csv_row.cpp

@@ -204,12 +204,7 @@ namespace csv {
     }
 
     CSV_INLINE CSVRow::iterator::pointer CSVRow::iterator::operator->() const {
-        // Using CSVField * as pointer type causes segfaults in MSVC debug builds
-        #ifdef _MSC_BUILD
         return this->field;
-        #else
-        return this->field.get();
-        #endif
     }
 
     CSV_INLINE CSVRow::iterator& CSVRow::iterator::operator++() {

include/internal/csv_row.hpp

@@ -337,15 +337,7 @@ namespace csv {
 #ifndef DOXYGEN_SHOULD_SKIP_THIS
             using value_type = CSVField;
             using difference_type = int;
-
-            // Using CSVField * as pointer type causes segfaults in MSVC debug builds
-            // but using shared_ptr as pointer type won't compile in g++
-#ifdef _MSC_BUILD
             using pointer = std::shared_ptr<CSVField>;
-#else
-            using pointer = CSVField * ;
-#endif
-
             using reference = CSVField & ;
             using iterator_category = std::random_access_iterator_tag;
 #endif