Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential misuse of parameter input #17

Open
ly1112 opened this issue Dec 25, 2022 · 0 comments
Open

Potential misuse of parameter input #17

ly1112 opened this issue Dec 25, 2022 · 0 comments

Comments

@ly1112
Copy link

ly1112 commented Dec 25, 2022

Dear author, thank you so much for sharing your work, but I may ask if there may be a potential misuse of parameter input. Could you please take the time to check it?

in your main.py, lines 53 to 54, you use:

if (loss_type=='dilate'):
loss, loss_shape, loss_temporal = dilate_loss(target,outputs,alpha, gamma, device)
so the first arg is target(ground truth) and the second arg is output (prediction)

But in your dilate_loss.py, line 5, you use:

def dilate_loss(outputs, targets, alpha, gamma, device):

So the first arg is changed to output (prediction) and the second arg is the target(ground truth).

So may I ask should the code in main.py, lines 53 to 54, to be changed as:

if (loss_type=='dilate'):
loss, loss_shape, loss_temporal = dilate_loss(outputs,target,alpha, gamma, device)

Because in your paper, you mention the latter parameter is the ground truth.

Thanks a lot! Looking forward to your reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant