You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 27, 2023. It is now read-only.
I was trying out the library, so I followed the README, but got a problem with corner radius:
riv.setCornerRadius(10)
Was failing with ResourceNotFound exception. From the source code I found out that setCornerRadius(float) and setCornerRadius(int) work very differently, and in order to directly set the corner radius one should make sure that the floatish method is used.
I find it very misleading, perhaps method setCornerRadius(int resId) should be changed to setCornerRadiusFromResource(int resId). I understand that it might not be possible at the moment because of backward compatibility, but please consider that change on major update.
I'll also submit a PR with the change in README's code example.
The text was updated successfully, but these errors were encountered:
hm I see your point, there will probably be some minor breaking changes in the next build anyway, so this might not be bad. I'd probably name it setCornerRadiusRes though.
Hi.
I was trying out the library, so I followed the README, but got a problem with corner radius:
Was failing with ResourceNotFound exception. From the source code I found out that
setCornerRadius(float)
andsetCornerRadius(int)
work very differently, and in order to directly set the corner radius one should make sure that the floatish method is used.I find it very misleading, perhaps method
setCornerRadius(int resId)
should be changed tosetCornerRadiusFromResource(int resId)
. I understand that it might not be possible at the moment because of backward compatibility, but please consider that change on major update.I'll also submit a PR with the change in README's code example.
The text was updated successfully, but these errors were encountered: