Fix reported CRAN check failure #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 41 41
Lines 4468 4471 +3
=========================================
+ Hits 4468 4471 +3
Continue to review full report at Codecov.
|
weshinsley
approved these changes
Sep 20, 2021
There was a problem hiding this comment.
Looks good - frustrating to have to do this because of external forces...
Tested on Windows - all good
Also verified that on the server node, this fixes issue #301 as far as orderly usage goes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the current failing builds here: https://cran.r-project.org/web/checks/check_results_orderly.html
My belief as to what is going on is in the comment in test-run.R: knitr now requires that anyone knitting a markdown (rather than sweave) document includes the dependency on
markdowneven though that is clearly a knitr dependency (see yihui/knitr#1864), then there's a workaround for this unfortunate decision in knitr which seems to break our package (yihui/knitr@9a80a00). However, this breaks differently on CRAN machines and ours because this workaround tries not to error and instead silently writes an empty file, so the test fails.Having updated things to include knitr's dependency among ours (as I guess hundreds of packages have had to?) I've also just removed this test from within those running on CRAN as I can't be sure that this is real reason - it's still unexplained why only devel and patched builds are failing but that might be lag. In any case given we're in workaround-ception territory here, it feels best not to expose the package to removal based on this situation.
Also includes a fix for #301, by including an explicit check for the path. This should give a better error for the user even if the zip package did throw its error.
Also fixes vimc-4345