Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing package-lock.json #878

Open
krokwen opened this issue Mar 6, 2023 · 1 comment
Open

Missing package-lock.json #878

krokwen opened this issue Mar 6, 2023 · 1 comment

Comments

@krokwen
Copy link

krokwen commented Mar 6, 2023

Describe the bug
Due to missing package-lock.json I'm unable to build working app (building on linux).
Since the last release many things were changed in the nodejs world and no longer works...

Due to this i'm instantly getting an error about data download.
Also, locale lables are broken in the build app (but works with 'npm start')

So, please include package-lock.json. This file is aimed to allow other developers reproduce full original packages state.

To Reproduce
Steps to reproduce the behavior:
Just build and run app as described in readme.

  1. git checkout v1.2.1
  2. cd ExilenceNextApp
  3. npm i
  4. npm run smoke-build-linux
  5. cd dist
  6. ./appimage
  7. Now you don't see any localized labels in app
  8. You see the "error.title.get_prices_for_leagues" with 404 error

Expected behavior
Localization labels works
Price data downloads.

Screenshots
image

Version
latest release, v1.2.1

Additional context
Linux build. Fedora 37, Wayland, SELinux enabled.
Tried with node 14 and 16 (installed with nvm)
Also tried to run unpacked app (linux-unpacked/exilence-next-app)

@krokwen
Copy link
Author

krokwen commented Mar 6, 2023

somehow i missed that package-lock.json exists... but it was update 2yr ago, and keep updating on 'npm i'...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant