Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE 11 / fullscreen hack should be replaced with proper fullscreen #1115

Closed
leray opened this issue Mar 26, 2014 · 3 comments
Closed

IE 11 / fullscreen hack should be replaced with proper fullscreen #1115

leray opened this issue Mar 26, 2014 · 3 comments

Comments

@leray
Copy link

leray commented Mar 26, 2014

IE 11 supports fullscreen now, however videojs uses its own hack to stretch the parent container to 100% x 100%. This should be replaced to a proper fullscreen if IE supports it.

@leray
Copy link
Author

leray commented Mar 26, 2014

// RequestFullscreen API

...
// IE 11
if (document.msExitFullscreen) {
prefix = "ms";
requestFS.requestFn = "msRequestFullscreen";
requestFS.isFullScreen = "msFullscreenEnabled";
requestFS.eventName = "MSFullscreenChange";
requestFS.cancelFn = "msExitFullscreen";
}
...

this will enable fullscreen support in IE 11

@gkatsev
Copy link
Member

gkatsev commented Mar 26, 2014

This is a known issue that is being tracked in #673

@leray
Copy link
Author

leray commented Mar 26, 2014

my bad, haven't noticed.

@heff heff added the duplicate label Mar 26, 2014
@heff heff closed this as completed Mar 26, 2014
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants