Skip to content

Commit

Permalink
chore: Update CI and release workflows (#431)
Browse files Browse the repository at this point in the history
* Update deprecated set-output command.
* Update actions to use Node 16 rather than Node 12.
  • Loading branch information
philjhale authored May 24, 2023
1 parent 055204a commit dc56f1b
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 11 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
should-skip-job: ${{steps.skip-check.outputs.should_skip}}
steps:
- id: skip-check
uses: fkirc/skip-duplicate-actions@v2.1.0
uses: fkirc/skip-duplicate-actions@v5.3.0
with:
github_token: ${{github.token}}

Expand All @@ -30,10 +30,10 @@ jobs:
runs-on: ${{matrix.os}}
steps:
- name: checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: read node version from .nvmrc
run: echo ::set-output name=NVMRC::$(cat .nvmrc)
run: echo "NVMRC=$(cat .nvmrc)" >> $GITHUB_OUTPUT
shell: bash
id: nvm

Expand All @@ -47,7 +47,7 @@ jobs:
run: pulseaudio -D

- name: setup node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: '${{steps.nvm.outputs.NVMRC}}'
cache: npm
Expand All @@ -61,12 +61,12 @@ jobs:
run: npm i --prefer-offline --no-audit

- name: run npm test
uses: GabrielBB/xvfb-action@v1
uses: coactions/setup-xvfb@v1
with:
run: npm run test

- name: coverage
uses: codecov/codecov-action@v1
uses: codecov/codecov-action@v3
with:
token: ${{secrets.CODECOV_TOKEN}}
files: './test/dist/coverage/coverage-final.json'
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,19 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v3
# We neeed to fetch the entire history as conventional-changelog needs
# access to any number of git commits to build the changelog.
with:
fetch-depth: 0

- name: read node version from .nvmrc
run: echo ::set-output name=NVMRC::$(cat .nvmrc)
run: echo "NVMRC=$(cat .nvmrc)" >> $GITHUB_OUTPUT
shell: bash
id: nvm

- name: setup node
uses: actions/setup-node@v2
uses: actions/setup-node@v3
with:
node-version: '${{steps.nvm.outputs.NVMRC}}'
cache: npm
Expand All @@ -43,7 +43,7 @@ jobs:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}

- name: Check if this is a pre-release
run: echo ::set-output name=IS_PRE_RELEASE::$(npx -p not-prerelease is-prerelease && echo "true" || echo "false")
run: echo "IS_PRE_RELEASE=$(npx -p not-prerelease is-prerelease && echo "true" || echo "false")" >> $GITHUB_OUTPUT
id: pre-release-check

- name: truncate CHANGELOG.md so that we can get the current versions changes only
Expand All @@ -53,7 +53,7 @@ jobs:
run: npx -p @videojs/update-changelog vjs-update-changelog --run-on-prerelease

- name: get dashed package version for netlify
run: echo ::set-output name=VERSION::$(node -e "process.stdout.write(require('./package.json').version.split('.').join('-'))")
run: echo "VERSION=$(node -e "process.stdout.write(require('./package.json').version.split('.').join('-'))")" >> $GITHUB_OUTPUT
id: get-version
shell: bash
if: env.NETLIFY_BASE != ''
Expand Down

0 comments on commit dc56f1b

Please sign in to comment.