Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails with: window.location.hash.includes is not a function #118

Open
yuvipanda opened this issue Mar 19, 2016 · 2 comments
Open

Fails with: window.location.hash.includes is not a function #118

yuvipanda opened this issue Mar 19, 2016 · 2 comments

Comments

@yuvipanda
Copy link
Contributor

On Firefox 38, Linux, just opening the website doesn't really seem to work - I end up with this error in JS console, and JS execution is halted.

I can't seem to get a stacktrace because there are no sourcemaps for the minified code.
@victorb
Copy link
Owner

victorb commented Mar 19, 2016

Oh, neither of those things are any good. includes seems to be still too new so I'll fix this by using indexOf instead.

Also, I'll add source maps so I'll be easier to see where things are coming from.

Thanks for spotting these issues!

@yuvipanda yuvipanda mentioned this issue Mar 20, 2016
Merged
@yuvipanda
Copy link
Contributor Author

I've sent a PR for the indexOf issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yuvipanda @victorb