Skip to content

Commit b53a498

Browse files
asarkar84asarkar84
authored
[BillingRP] Correcting the API response as per the actual implementation. Removing LineOfCredit API from 2019 version, it was never supported. (Azure#8290)
* Added missing fields and corrected enum values as per actual implementation * Removing unsupported LineOfCredit API Removing unsupported LineOfCredit API * Delete IncreaseLineOfCreditBySubscription.json
1 parent 0603855 commit b53a498

File tree

6 files changed

+23
-223
lines changed

6 files changed

+23
-223
lines changed

‎specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/billing.json‎

Lines changed: 13 additions & 148 deletions
Original file line numberDiff line numberDiff line change
@@ -4592,102 +4592,6 @@
45924592
}
45934593
}
45944594
}
4595-
},
4596-
"/subscriptions/{subscriptionId}/providers/Microsoft.Billing/billingAccounts/default/lineOfCredit/default": {
4597-
"get": {
4598-
"tags": [
4599-
"LineOfCredits"
4600-
],
4601-
"x-ms-examples": {
4602-
"LineOfCreditBySubscription": {
4603-
"$ref": "./examples/LineOfCreditBySubscription.json"
4604-
}
4605-
},
4606-
"operationId": "LineOfCredits_Get",
4607-
"description": "Get the current line of credit.",
4608-
"parameters": [
4609-
{
4610-
"$ref": "#/parameters/apiVersionParameter"
4611-
},
4612-
{
4613-
"$ref": "#/parameters/subscriptionIdParameter"
4614-
}
4615-
],
4616-
"responses": {
4617-
"200": {
4618-
"description": "OK. The request has succeeded.",
4619-
"schema": {
4620-
"$ref": "#/definitions/LineOfCredit"
4621-
}
4622-
},
4623-
"default": {
4624-
"description": "Error response describing why the operation failed.",
4625-
"schema": {
4626-
"$ref": "#/definitions/ErrorResponse"
4627-
}
4628-
}
4629-
}
4630-
},
4631-
"put": {
4632-
"tags": [
4633-
"LineOfCredits"
4634-
],
4635-
"operationId": "LineOfCredits_Update",
4636-
"x-ms-long-running-operation": true,
4637-
"x-ms-long-running-operation-options": {
4638-
"final-state-via": "location"
4639-
},
4640-
"x-ms-examples": {
4641-
"IncreaseLineOfCreditBySubscription": {
4642-
"$ref": "./examples/IncreaseLineOfCreditBySubscription.json"
4643-
}
4644-
},
4645-
"description": "Increase the current line of credit.",
4646-
"parameters": [
4647-
{
4648-
"$ref": "#/parameters/apiVersionParameter"
4649-
},
4650-
{
4651-
"$ref": "#/parameters/subscriptionIdParameter"
4652-
},
4653-
{
4654-
"name": "parameters",
4655-
"in": "body",
4656-
"required": true,
4657-
"schema": {
4658-
"$ref": "#/definitions/LineOfCredit"
4659-
},
4660-
"description": "Parameters supplied to the increase line of credit operation."
4661-
}
4662-
],
4663-
"responses": {
4664-
"200": {
4665-
"description": "OK. The request has succeeded.",
4666-
"schema": {
4667-
"$ref": "#/definitions/LineOfCredit"
4668-
}
4669-
},
4670-
"202": {
4671-
"description": "Accepted. Line of credit increase is in progress.",
4672-
"headers": {
4673-
"Location": {
4674-
"description": "Location URI to poll for result.",
4675-
"type": "string"
4676-
},
4677-
"Retry-After": {
4678-
"description": "Recommends the retryable time after receiving this.",
4679-
"type": "integer"
4680-
}
4681-
}
4682-
},
4683-
"default": {
4684-
"description": "Error response describing why the operation failed.",
4685-
"schema": {
4686-
"$ref": "#/definitions/ErrorResponse"
4687-
}
4688-
}
4689-
}
4690-
}
46914595
}
46924596
},
46934597
"definitions": {
@@ -5833,6 +5737,11 @@
58335737
"description": "The date this billing instruction is no longer in effect.",
58345738
"type": "string",
58355739
"format": "date-time"
5740+
},
5741+
"creationDate": {
5742+
"description": "The date this billing instruction was created.",
5743+
"type": "string",
5744+
"format": "date-time"
58365745
}
58375746
}
58385747
},
@@ -6281,10 +6190,9 @@
62816190
"description": "Invoice status.",
62826191
"type": "string",
62836192
"enum": [
6284-
"PastDue",
62856193
"Due",
6286-
"Paid",
6287-
"Void"
6194+
"OverDue",
6195+
"Paid"
62886196
],
62896197
"readOnly": true,
62906198
"x-ms-enum": {
@@ -6357,6 +6265,11 @@
63576265
"items": {
63586266
"$ref": "#/definitions/PaymentProperties"
63596267
}
6268+
},
6269+
"subscriptionId": {
6270+
"description": "The subscription id this invoice belongs to.",
6271+
"type": "string",
6272+
"readOnly": true
63606273
}
63616274
}
63626275
},
@@ -6409,7 +6322,7 @@
64096322
"enum": [
64106323
"Invoice",
64116324
"VoidNote",
6412-
"Receipt",
6325+
"TaxReceipt",
64136326
"CreditNote"
64146327
],
64156328
"readOnly": true,
@@ -7606,54 +7519,6 @@
76067519
}
76077520
}
76087521
},
7609-
"LineOfCredit": {
7610-
"description": "Line of credit resource.",
7611-
"type": "object",
7612-
"allOf": [
7613-
{
7614-
"$ref": "#/definitions/Resource"
7615-
}
7616-
],
7617-
"properties": {
7618-
"properties": {
7619-
"description": "A line of credit.",
7620-
"x-ms-client-flatten": true,
7621-
"$ref": "#/definitions/LineOfCreditProperties"
7622-
}
7623-
}
7624-
},
7625-
"LineOfCreditProperties": {
7626-
"description": "The properties of the line of credit.",
7627-
"properties": {
7628-
"creditLimit": {
7629-
"description": "The current credit limit.",
7630-
"$ref": "#/definitions/Amount",
7631-
"readOnly": false
7632-
},
7633-
"reason": {
7634-
"description": "The reason for the line of credit status when not approved.",
7635-
"type": "string",
7636-
"readOnly": true
7637-
},
7638-
"remainingBalance": {
7639-
"description": "Remaining balance.",
7640-
"$ref": "#/definitions/Amount",
7641-
"readOnly": true
7642-
},
7643-
"status": {
7644-
"description": "The line of credit status.",
7645-
"type": "string",
7646-
"enum": [
7647-
"Approved",
7648-
"Rejected"
7649-
],
7650-
"x-ms-enum": {
7651-
"name": "status",
7652-
"modelAsString": true
7653-
}
7654-
}
7655-
}
7656-
},
76577522
"Action": {
76587523
"description": "the action the caller allowed to do",
76597524
"type": "string",

‎specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/BillingSubscriptionInvoice.json‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"properties": {
1515
"dueDate": "2018-03-01T17:32:28Z",
1616
"invoiceDate": "2018-02-01T17:32:28Z",
17-
"status": "PastDue",
17+
"status": "Paid",
1818
"amountDue": {
1919
"currency": "USD",
2020
"value": 2000.00
@@ -46,9 +46,10 @@
4646
"paymentMethodFamily": "CreditCard",
4747
"paymentMethodType": "visa"
4848
}
49-
]
49+
],
50+
"subscriptionId": "55000000-0000-0000-0000-000000000011"
5051
}
51-
}
52+
}
5253
}
5354
}
5455
}

‎specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/BillingSubscriptionInvoicesList.json‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@
2525
"invoicePeriodStartDate": "2018-01-01T17:32:28Z",
2626
"invoicePeriodEndDate": "2018-01-15T17:32:28Z",
2727
"invoiceType": "AzureServices",
28-
"purchaseOrderNumber": "123456"
28+
"purchaseOrderNumber": "123456",
29+
"subscriptionId": "55000000-0000-0000-0000-000000000011"
2930
}
3031
},
3132
{
@@ -35,7 +36,7 @@
3536
"properties": {
3637
"dueDate": "2018-03-01T17:32:28Z",
3738
"invoiceDate": "2018-02-01T17:32:28Z",
38-
"status": "PastDue",
39+
"status": "Paid",
3940
"amountDue": {
4041
"currency": "USD",
4142
"value": 2000.00
@@ -67,7 +68,8 @@
6768
"paymentMethodFamily": "CreditCard",
6869
"paymentMethodType": "visa"
6970
}
70-
]
71+
],
72+
"subscriptionId": "55000000-0000-0000-0000-000000000011"
7173
}
7274
}
7375
]

‎specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/IncreaseLineOfCreditBySubscription.json‎

Lines changed: 0 additions & 41 deletions
This file was deleted.

‎specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/InvoicesListByBillingProfile.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@
6767
"properties": {
6868
"dueDate": "2018-03-01T17:32:28Z",
6969
"invoiceDate": "2018-01-01T17:32:28Z",
70-
"status": "PastDue",
70+
"status": "Due",
7171
"amountDue": {
7272
"currency": "USD",
7373
"value": 2000.00

‎specification/billing/resource-manager/Microsoft.Billing/preview/2019-10-01-preview/examples/LineOfCreditBySubscription.json‎

Lines changed: 0 additions & 27 deletions
This file was deleted.

0 commit comments

Comments
 (0)