Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some issue of Optimize the write performance when host is down #5673

Merged
merged 13 commits into from
Sep 19, 2023
Merged

fix some issue of Optimize the write performance when host is down #5673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5690ea8
RaftPart creates a separate execution thread pool to prevent blockin…
tangyuanzhang Feb 27, 2023
96658cc
raft part use separate thread pool
tangyuanzhang Mar 6, 2023
6e81584
Merge branch 'vesoft-inc:master' into master
tangyuanzhang May 4, 2023
77ebff2
Prevent the heartbeat time from going back and causing leader lease i…
tangyuanzhang May 4, 2023
dca571c
Merge branch 'master' into master
critical27 May 12, 2023
6dea1c5
Merge branch 'vesoft-inc:master' into master
tangyuanzhang May 12, 2023
647b35f
Merge branch 'vesoft-inc:master' into master
tangyuanzhang May 16, 2023
c98d061
Merge branch 'vesoft-inc:master' into master
tangyuanzhang May 30, 2023
a8bcf3e
Merge branch 'vesoft-inc:master' into master
tangyuanzhang Aug 15, 2023
949e663
fix some of Optimize the write performance when host is down
tangyuanzhang Aug 15, 2023
afc0e3a
Merge branch 'master' into dev_storage_bugfix
Sophie-Xie Aug 16, 2023
bc46595
Merge branch 'master' into dev_storage_bugfix
Sophie-Xie Sep 5, 2023
860c0b0
update comment
tangyuanzhang Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/kvstore/raftex/Host.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,11 +426,12 @@ folly::Future<cpp2::HeartbeatResponse> Host::sendHeartbeat(
if (t.hasException()) {
using TransportException = apache::thrift::transport::TTransportException;
auto exWrapper = std::move(t).exception();
VLOG(2) << self->idStr_ << "Heartbeat: " << exWrapper.what();
auto exception = exWrapper.get_exception<TransportException>();
VLOG(2) << self->idStr_ << "Heartbeat: " << exception->what();
// If we keeps receiving NOT_OPEN exception after some HB intervals,
// If we keeps receiving NOT_OPEN and TIMED_OUT exception after some HB intervals,
// we can assume that the peer is down so we mark paused_ as true
if (exception && exception->getType() == TransportException::NOT_OPEN) {
if (exception && (exception->getType() == TransportException::NOT_OPEN ||
exception->getType() == TransportException::TIMED_OUT)) {
if (!self->paused_) {
auto now = time::WallClock::fastNowInMilliSec();
if (now - self->lastHeartbeatTime_ >=
Expand Down
1 change: 1 addition & 0 deletions src/kvstore/raftex/Host.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ class Host final : public std::enable_shared_from_this<Host> {
committedLogId_ = 0;
sendingSnapshot_ = false;
followerCommittedLogId_ = 0;
lastHeartbeatTime_ = 0;
}

/**
Expand Down
Loading