Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the graph iterator implementation into different files #5312

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Feb 6, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

NOT change anything, only split the Iterator implementation into different files.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Feb 6, 2023
@yixinglu yixinglu marked this pull request as ready for review February 6, 2023 02:45
@yixinglu yixinglu changed the title Cleanup graph dataset iterators Split the graph iterator implementation into different files Feb 6, 2023
czpmango
czpmango previously approved these changes Feb 6, 2023
@czpmango
Copy link
Contributor

czpmango commented Feb 6, 2023

Please fix the conflicts.

@Sophie-Xie Sophie-Xie merged commit c988242 into vesoft-inc:master Feb 6, 2023
@yixinglu yixinglu deleted the cleanup-iterator branch February 6, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants