Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move probe rows of Join. #4283

Merged
merged 2 commits into from
Jun 13, 2022

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented May 25, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #4186

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added type/enhancement Type: make the code neat or more efficient ready-for-testing PR: ready for the CI test labels May 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #4283 (bda2797) into master (fcbab77) will decrease coverage by 0.00%.
The diff coverage is 88.70%.

@@            Coverage Diff             @@
##           master    #4283      +/-   ##
==========================================
- Coverage   84.88%   84.87%   -0.01%     
==========================================
  Files        1343     1343              
  Lines      133363   133408      +45     
==========================================
+ Hits       113199   113235      +36     
- Misses      20164    20173       +9     
Impacted Files Coverage Δ
src/graph/executor/query/InnerJoinExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/JoinExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/LeftJoinExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/RollUpApplyExecutor.h 100.00% <ø> (ø)
src/meta/processors/admin/RestoreProcessor.cpp 67.47% <40.00%> (-0.59%) ⬇️
src/graph/executor/query/RollUpApplyExecutor.cpp 57.84% <50.00%> (+13.28%) ⬆️
src/graph/executor/query/LeftJoinExecutor.cpp 98.68% <90.90%> (-1.32%) ⬇️
src/graph/executor/query/InnerJoinExecutor.cpp 98.96% <96.87%> (-1.04%) ⬇️
src/graph/executor/Executor.h 100.00% <100.00%> (ø)
src/graph/executor/query/JoinExecutor.cpp 79.31% <100.00%> (+3.31%) ⬆️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b35538...bda2797. Read the comment docs.

@Sophie-Xie Sophie-Xie added this to the v3.2.0 milestone May 27, 2022
@Sophie-Xie Sophie-Xie merged commit 7ca2bad into vesoft-inc:master Jun 13, 2022
@Shylock-Hg Shylock-Hg deleted the optimize/move-join-probe-row branch June 13, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move input rows of Join based on lifetime analysis
5 participants