-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable mixed usage of cypher & ngql #3506
disable mixed usage of cypher & ngql #3506
Conversation
3d92ad6
to
b2cd87f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think disable output to open cyher is enough, like #2537 |
It's a great job. But there would have a more compatible implementation of |
| n | | ||
| ("Tim Duncan") | | ||
| ("Tony Parker") | | ||
Then a SyntaxError should be raised at runtime: syntax error near `UNION' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not right, MATCH ... UNION MATCH ... is a legal cypher syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
What type of PR is this?
What does this PR do?
disable mixed usesage of cypher & ngql
Which issue(s)/PR(s) this PR relates to?
close #3477
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context/ Design document:
Checklist:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: