-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow users to choose linker like lld to make build faster. #3460
Conversation
install lld when pull request , will set lld as default linker.
[* ] Documentation affected --> Does this PR affect the document? |
Yes . In the future, user need to install lld first. And we may set lld as default linker to build fast. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you shouldn't change the linker config, just by passing the NEBULA_USE_LINKER
into cmake in configuring stage.
please see the .github/workflows/pull_request.yml content
No, the linker config is explicit telling what kind of linker is supported. If set it to CI, Many developer will not notice it, Also Then Can Set NEBULA_USE_LINKER to wrong value like 'notvalidld'. Set it in linkerconfig file developer can know what kind of linker supported. |
make sense. And only thing needing to do is just to verify the compiling in multi-platform. |
Codecov Report
@@ Coverage Diff @@
## master #3460 +/- ##
==========================================
+ Coverage 85.19% 85.22% +0.02%
==========================================
Files 1306 1307 +1
Lines 122158 122244 +86
==========================================
+ Hits 104078 104179 +101
+ Misses 18080 18065 -15
Continue to review full report at Codecov.
|
What type of PR is this?
What does this PR do?
user can chose linker like lld to make build more faster.
Which issue(s)/PR(s) this PR relates to?
none
Special notes for your reviewer, ex. impact of this fix, etc:
If ci can install lld before build in the future, then can make lld default linker. Now still use bfd as default.
Additional context:
none
Checklist:
user in the future need to install lld first to link faster.
Release notes:
Please confirm whether to reflect in release notes and how to describe:
support lld linker and make build a litter faster