Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add more metrics #3446

Merged
merged 12 commits into from
Dec 23, 2021
Merged

add more metrics #3446

merged 12 commits into from
Dec 23, 2021

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Dec 10, 2021 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

As title

Which issue(s)/PR(s) this PR relates to?

Close #3239

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist：

  • Documentation affected （Please add the label if documentation needs to be modified.)
  • Incompatible （If it is incompatible, please describe it and add corresponding label.）
  • Need to cherry-pick （If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes：

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@jievince jievince changed the title add more metrics [WIP]add more metrics Dec 10, 2021
@jievince jievince requested review from czpmango and removed request for czpmango December 10, 2021 03:50
@jievince jievince force-pushed the counters branch 3 times, most recently from 8e5ecd0 to ddfce14 Compare December 15, 2021 03:10
@jievince jievince added the ready-for-testing PR: ready for the CI test label Dec 15, 2021
@jievince jievince force-pushed the counters branch 3 times, most recently from ef77118 to e4b9eec Compare December 15, 2021 05:44
@jievince jievince changed the title [WIP]add more metrics add more metrics Dec 16, 2021
@Sophie-Xie Sophie-Xie requested a review from Aiee December 16, 2021 08:56
@jievince jievince force-pushed the counters branch 2 times, most recently from cf23ad4 to 9d29760 Compare December 21, 2021 07:40
@Aiee
Copy link
Contributor

Aiee commented Dec 23, 2021

Seems this PR has an impact on the performance?

@jievince
Copy link
Contributor Author

jievince commented Dec 23, 2021 •
edited
Loading

Seems this PR has an impact on the performance?

Yes, there is a slight performance impact when statsmanager finds a specific metric, but the impact is minimal.

@jievince jievince requested review from yixinglu and removed request for yixinglu December 23, 2021 12:41
@critical27 critical27 merged commit ff1f4eb into vesoft-inc:master Dec 23, 2021
@jamieliu1023 jamieliu1023 mentioned this pull request Dec 25, 2021
Closed
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czpmango czpmango czpmango approved these changes

@Aiee Aiee Aiee approved these changes

@nevermore3 nevermore3 nevermore3 approved these changes

@yixinglu yixinglu Awaiting requested review from yixinglu

@randomJoe211 randomJoe211 Awaiting requested review from randomJoe211

Assignees
No one assigned
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more counters
6 participants
@jievince @Aiee @nevermore3 @czpmango @critical27 @Sophie-Xie