-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add duration. #3338
Add duration. #3338
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3338 +/- ##
========================================
Coverage 85.19% 85.20%
========================================
Files 1304 1306 +2
Lines 121308 122162 +854
========================================
+ Hits 103352 104084 +732
- Misses 17956 18078 +122 ☔ View full report in Codecov by Sentry. |
could you add some tests for the scenario? |
Added. And support to store it. |
# TODO don't allow different sign | ||
# | {months: 1, days: -14, hours: 16, minutes: -12, seconds: 70} | '1984-10-28' | '1984-09-25' | | ||
# TODO support decimal | ||
# | {years: 12.5, months: 5.5, days: 14.5, hours: 16.5, minutes: 12.5, seconds: 70.5} | '1997-10-11' | '1971-10-12' | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the behavior for these cases now?
What type of PR is this?
What does this PR do?
Related to #3101
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist:
Release notes:
Please confirm whether to reflect in release notes and how to describe: