Fixed an issue where the server still started with a wrong ip/host. #3057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
reviewed
Oct 14, 2021
src/common/network/NetworkUtils.cpp
Outdated
Comment on lines
327
to
328
| auto result = std::find_if( | ||
| ips.begin(), ips.end(), [hostOrIp](const auto& val) { return hostOrIp == val; }); |
There was a problem hiding this comment.
auto iter = std::find(ips.begin(), ips.end(), hostOrIp);
src/common/network/NetworkUtils.cpp
Outdated
Comment on lines
335
to
338
| auto hostStatus = resolveHost(hostOrIp, 0); | ||
| if (!hostStatus.ok()) { | ||
| return hostStatus.status(); | ||
| } |
There was a problem hiding this comment.
NG_RETURN_IF_ERROR(resolveHost(hostOrIp, 0));
src/common/network/NetworkUtils.cpp
Outdated
Comment on lines
313
to
315
| const std::regex ipv4( | ||
| "(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\." | ||
| "(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\." | ||
| "(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\\." | ||
| "(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)"); |
There was a problem hiding this comment.
"((25[0-5]|2[0-4][0-9]|[01]?[0-9]{1,2})\\.){3}(25[0-5]|2[0-4][0-9]|[01]?[0-9]{1,2})"
src/common/network/NetworkUtils.cpp
Outdated
| "(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)"); | ||
| if (std::regex_match(hostOrIp, ipv4)) { | ||
| const std::regex loopbackOrAny( | ||
| "^127(?:\\.[0-9]+){0,2}\\.[0-9]+$|^(?:0*\\:)*?:?0*1$|0\\.0\\.0\\.0"); |
There was a problem hiding this comment.
"^127(?:\\.[0-9]+){0,2}\\.[0-9]+$|^(?:0*\\:)*?:?0*1$|(0\\.){3}0"
Codecov Report
@@ Coverage Diff @@
## master #3057 +/- ##
==========================================
+ Coverage 84.30% 85.06% +0.76%
==========================================
Files 1287 1287
Lines 115636 115720 +84
==========================================
+ Hits 97483 98436 +953
+ Misses 18153 17284 -869
Continue to review full report at Codecov.
|
CPWstatic
force-pushed
the
fix_wrong_local_ip
branch
from
41b814e
to
1aee757
Compare
nevermore3
approved these changes
Oct 18, 2021
yixinglu
approved these changes
Oct 19, 2021
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 20, 2021
…3057) * Fix wrong local ip. * Address comment.
bright-starry-sky
pushed a commit
that referenced
this pull request
Oct 20, 2021
* Fixed an issue where the server still started with a wrong ip/host (#3057) * Fix wrong local ip. * Address comment. * Fix alter drop (#3036) * disable modify same col * add test case * refactor ddl * fix pytest error * address comment Co-authored-by: Yee <[email protected]> * fix fetch vertex properties(vertex) bug (#3120) * fix fetch vertex properties(vertex) bug * address comment Co-authored-by: Yee <[email protected]> * fix go yield bug (#3128) * fix go yield bug * add test case * Remove unnecessary check (#3112) Co-authored-by: cpw <[email protected]> Co-authored-by: Yee <[email protected]> * fix go mTOn filter bug (#3144) * fix go mTOn filter bug * add test case * Geo spatial: 3. geography schema, data, index and optimization (#3043) * Geo spatial: 3. geography data and index Co-authored-by: cpw <[email protected]> Co-authored-by: jimingquan <[email protected]> Co-authored-by: Yee <[email protected]> Co-authored-by: Yichen Wang <[email protected]> Co-authored-by: jie.wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #2932 first.
graph,meta,storagenow bind to0.0.0.0automatically. The configuration oflocal_ipis only used as an identifier of local host for graph and meta.I found that issue #2932 has another one problem. Now the meta identify the graph/storage through the
local_ipwe talk above which makes overwritten problem when thelocal_ipis duplicated.