Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect result of optional match statement #4869

Closed
czpmango opened this issue Nov 14, 2022 · 5 comments
Closed

Incorrect result of optional match statement #4869

czpmango opened this issue Nov 14, 2022 · 5 comments
Assignees
Labels
affects/none PR/issue: this bug affects none version. need to discuss Solution: issue or PR without a clear conclusion on whether to handle it process/done Process of bug severity/major Severity of bug type/bug Type: something is unexpected wontfix Solution: this will not be worked on recently
Milestone

Comments

@czpmango
Copy link
Contributor

czpmango commented Nov 14, 2022

Describe the bug (required)
The predicate in optional match statement is not in effect.

Your Environments (required)
nebula v3.2

How To Reproduce(required)

(root@nebula) [nba]> optional match (v) where id(v) in ["Tim Duncan","Tony Parker"] and false return id(v)
+---------------+
| id(v)         |
+---------------+
| "Tim Duncan"  |
| "Tony Parker" |
+---------------+
Got 2 rows (time spent 2808/3080 us)

Expected behavior

root@nebula> optional match (v) where false return v;
+------+
| v    |
+------+
| NULL |
+------+

Additional context
We should provide support for optional semantics at the implementation layer, such as providing corresponding physical operators.

@czpmango czpmango added the type/bug Type: something is unexpected label Nov 14, 2022
@czpmango czpmango changed the title Incorrect result of Incorrect result of optional match statement Nov 14, 2022
@Sophie-Xie Sophie-Xie added this to the v3.4.0 milestone Nov 14, 2022
@Sophie-Xie Sophie-Xie added the wontfix Solution: this will not be worked on recently label Nov 14, 2022
@Sophie-Xie
Copy link
Contributor

Discuss it offline with @nevermore3 : it doesn't need to be fixed.

@HarrisChu HarrisChu added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Dec 1, 2022
@Sophie-Xie Sophie-Xie added the need to discuss Solution: issue or PR without a clear conclusion on whether to handle it label Dec 5, 2022
@czpmango
Copy link
Contributor Author

czpmango commented Dec 5, 2022

Discuss it offline with @nevermore3 : it doesn't need to be fixed.

?? why?

@xtcyclist
Copy link
Contributor

xtcyclist commented Dec 5, 2022

Partially sharing the same reason with https://github.com/vesoft-inc/nebula-ent/issues/1458

@HarrisChu
Copy link
Contributor

why?+1

@HarrisChu HarrisChu added the severity/major Severity of bug label Dec 7, 2022
@github-actions github-actions bot removed the severity/none Severity of bug label Dec 7, 2022
@xtcyclist
Copy link
Contributor

Close optional match related issues.

@github-actions github-actions bot added the process/fixed Process of bug label Dec 21, 2022
@Hester-Gu Hester-Gu added the process/done Process of bug label Jan 13, 2023
@github-actions github-actions bot removed the process/fixed Process of bug label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/none PR/issue: this bug affects none version. need to discuss Solution: issue or PR without a clear conclusion on whether to handle it process/done Process of bug severity/major Severity of bug type/bug Type: something is unexpected wontfix Solution: this will not be worked on recently
Projects
None yet
Development

No branches or pull requests

6 participants