Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join related plan node misses  some dependencies when profiling some queries #4867

Open
yixinglu opened this issue Nov 12, 2022 · 2 comments
Assignees
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@yixinglu
Copy link
Contributor

yixinglu commented Nov 12, 2022

Please check the FAQ documentation before raising an issue

Describe the bug (required)

When we profile the query whose execution plan has join related plan node, we get the wrong dependencies in join plan node description, such as following table, the third column should have two dependencies, but now there is the only one.

-----+------------------+--------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------------------------------------------
| 28 | InnerJoin        | 27           | ver: 0, rows: 121229, execTime: 259us, totalTime: 9778us                                                                                                                                                                                        | outputVar: {                                              |
|    |                  |              |                                                                                                                                                                                                                                                 |   "colNames": [                                           |
|    |                  |              |                                                                                                                                                                                                                                                 |     "__COL_0",                                            |
|    |                  |              |                                                                                                                                                                                                                                                 |     "__COL_1",                                            |
|    |                  |              |                                                                                                                                                                                                                                                 |     "__COL_2",                                            |
|    |                  |              |                                                                                                                                                                                                                                                 |     "__COL_3",                                            |
|    |                  |              |                                                                                                                                                                                                                                                 |     "_vid",                                               |
|    |                  |              |                                                                                                                                                                                                                                                 |     "idCard",                                             |
|    |                  |              |                                                                                                                                                                                                                                                 |     "VertexID"                                            |
|    |                  |              |                                                                                                                                                                                                                                                 |   ],                                                      |
|    |                  |              |                                                                                                                                                                                                                                                 |   "type": "DATASET",                                      |
|    |                  |              |                                                                                                                                                                                                                                                 |   "name": "__Filter_9"                                    |
|    |                  |              |                                                                                                                                                                                                                                                 | }                                                         |
|    |                  |              |                                                                                                                                                                                                                                                 | inputVar: {                                               |
|    |                  |              |                                                                                                                                                                                                                                                 |   "rightVar": {                                           |
|    |                  |              |                                                                                                                                                                                                                                                 |     "__Limit_3": 0                                        |
|    |                  |              |                                                                                                                                                                                                                                                 |   },                                                      |
|    |                  |              |                                                                                                                                                                                                                                                 |   "leftVar": {                                            |
|    |                  |              |                                                                                                                                                                                                                                                 |     "__Filter_27": 0                                      |
|    |                  |              |                                                                                                                                                                                                                                                 |   }                                                       |
|    |                  |              |                                                                                                                                                                                                                                                 | }                                                         |
|    |                  |              |                                                                                                                                                                                                                                                 | hashKeys: [                                               |
|    |                  |              |                                                                                                                                                                                                                                                 |   "$__Filter_27._vid"                                     |
|    |                  |              |                                                                                                                                                                                                                                                 | ]                                                         |
|    |                  |              |                                                                                                                                                                                                                                                 | probeKeys: [                                              |
|    |                  |              |                                                                                                                                                                                                                                                 |   "$-.VertexID"                                           |
|    |                  |              |                                                                                                                                                                                                                                                 | ]                                                         |
|    |                  |              |                                                                                                                                                                                                                                                 | kind: InnerJoin                                           |
-----+------------------+--------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+------------------------------------------------------------

The Join plan node inheriting the SingleDependencyNode result in the incorrect result.

class Join : public SingleDependencyNode {
 public:
};

Your Environments (required)

  • OS: uname -a
  • Compiler: g++ --version or clang++ --version
  • CPU: lscpu
  • Commit id (e.g. a3ffc7d8)

How To Reproduce(required)

Steps to reproduce the behavior:

  1. Step 1
  2. Step 2
  3. Step 3

Expected behavior

Additional context

@yixinglu yixinglu added the type/bug Type: something is unexpected label Nov 12, 2022
@Sophie-Xie Sophie-Xie added this to the v3.4.0 milestone Nov 14, 2022
@Shylock-Hg Shylock-Hg self-assigned this Nov 18, 2022
@Shylock-Hg
Copy link
Contributor

What's the query?

@Shylock-Hg
Copy link
Contributor

It's by designed. Join has only one dependency, but BiJoin has two.

@Shylock-Hg Shylock-Hg reopened this Nov 23, 2022
@Shylock-Hg Shylock-Hg added type/enhancement Type: make the code neat or more efficient and removed type/bug Type: something is unexpected labels Nov 23, 2022
@Shylock-Hg Shylock-Hg removed their assignment Nov 23, 2022
@Sophie-Xie Sophie-Xie assigned MuYiYong and yixinglu and unassigned MuYiYong Dec 2, 2022
@Sophie-Xie Sophie-Xie removed this from the v3.4.0 milestone Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Development

No branches or pull requests

4 participants