Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all locks in meta with a single lock #3520

Closed
critical27 opened this issue Dec 21, 2021 · 1 comment · Fixed by #3904
Closed

Replace all locks in meta with a single lock #3520

critical27 opened this issue Dec 21, 2021 · 1 comment · Fixed by #3904
Assignees
Labels
type/enhancement Type: make the code neat or more efficient
Milestone

Comments

@critical27
Copy link
Contributor

After 1230 there won't be too much write in meta, so a single global lock is enough. Don't add so many lock, which is complicated, easy to forget, and error prone.

We can do it after 1230

@critical27 critical27 added the type/enhancement Type: make the code neat or more efficient label Dec 21, 2021
@Sophie-Xie Sophie-Xie added this to the v3.0.0 milestone Dec 21, 2021
@Sophie-Xie Sophie-Xie moved this from Todo to Backlog in Nebula Graph v3.0.0 Dec 21, 2021
@Sophie-Xie Sophie-Xie removed this from the v3.0.0 milestone Dec 31, 2021
@Sophie-Xie Sophie-Xie moved this from Todo to Backlog in Nebula Graph v3.1.0 Jan 20, 2022
@Sophie-Xie Sophie-Xie added this to the v3.1.0 milestone Jan 26, 2022
@critical27
Copy link
Contributor Author

This issue involves two aspects:

  1. Check every lock in LockUtils, unify them as much as possible. For example, use only one lock when related to schema, such as space/tag/edge/index/group/zone..., the remaining locks need to be considered as well.
  2. Make sure only one data write in every meta processors, especially pay attention to ActiveHostsMan and LastUpdateMan

@Sophie-Xie Sophie-Xie linked a pull request Feb 25, 2022 that will close this issue
11 tasks
Repository owner moved this from Backlog to Done in Nebula Graph v3.1.0 Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Type: make the code neat or more efficient
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants