-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove pwd & input pwd before import data #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's conflicted with my token refresh, we need to discuss about it tommor
@@ -137,8 +160,15 @@ class Import extends React.Component<IProps, IState> { | |||
} | |||
|
|||
const result = data.results?.[0]; | |||
|
|||
if (result?.taskStatus !== 'statusProcessing') { | |||
console.log('result', result); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
if (result.taskMessage) { | ||
message.warning(result.taskMessage); | ||
} | ||
console.log('status', result.taskStatus); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, you can squash the commits && remove the no use console
feat: remove pwd & input pwd before import data mod: code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#54 #56 #34