Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dynamic flags #293

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Conversation

MegaByte875
Copy link
Contributor

@MegaByte875 MegaByte875 commented Sep 22, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#289

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

creating cluster:
image

image
nebula-graph.io/last-applied-dynamic-flags: '{"accept_partial_success":"true","session_reclaim_interval_secs":"300","v":"2"}'
nebula-graph.io/last-applied-static-flags: '{"enable_http2_routing":"true","max_job_size":"36","max_sessions_per_ip_per_user":"10000","port":"8080","prioritize_intra_zone_reading":"true","redirect_stdout":"false","stderrthreshold":"0","stream_timeout_ms":"120000","sync_meta_when_use_space":"true"}'

updating config:
set dynamic flag v=2
image
image

set flag accept_partial_success to false and set port to 8081
graphd pod restart again
image

image
nebula-graph.io/last-applied-dynamic-flags: '{"accept_partial_success":"false","session_reclaim_interval_secs":"300","v":"2"}'
nebula-graph.io/last-applied-static-flags: '{"enable_http2_routing":"true","max_job_size":"36","max_sessions_per_ip_per_user":"10000","port":"8081","prioritize_intra_zone_reading":"true","redirect_stdout":"false","stderrthreshold":"0","stream_timeout_ms":"120000","sync_meta_when_use_space":"true"}'

scale graphd replicas to 2:
image

Copy link
Contributor

@veezhang veezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MegaByte875 MegaByte875 merged commit 25d6639 into vesoft-inc:release-1.6 Sep 22, 2023
MegaByte875 added a commit to MegaByte875/nebula-operator that referenced this pull request Sep 22, 2023
veezhang pushed a commit that referenced this pull request Sep 22, 2023
fix dynamic flags (#293)
@MegaByte875 MegaByte875 deleted the fix_flags branch October 27, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants