Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The effective time of space is not friendly to testing #552

Closed
jxnu-liguobin opened this issue Sep 20, 2023 · 2 comments
Closed

The effective time of space is not friendly to testing #552

jxnu-liguobin opened this issue Sep 20, 2023 · 2 comments
Labels
type/feature req Type: feature request

Comments

@jxnu-liguobin
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I am testing the Nebula application by testcontainers. Of course, testcontainers do not support nebula now, I have written a simple tool testcontainers-nebula.

The document suggests that creating a space requires a wait of 20 seconds before it becomes available, which is good for distributed systems, but it is cumbersome for testing, which means that you must retry or manually sleep. The latter is not easily achieved correctly in asynchronous programs, and the number of retries for the former is unknown.

For this issue, in zio, I had to use the eventually aspect to make my testing ultimately successful (Try again until successful), obviously, this is time-consuming and unknown, and may never succeed.

heartbeat_interval_secs It seems that the configuration controls this, but can it take effect immediately?

Describe the solution you'd like
For this, allowing clients to register callbacks to inform users in a timely manner or effective immediately?.

Describe alternatives you've considered

Additional context

@Nicole00
Copy link
Contributor

Nicole00 commented Oct 23, 2023

heartbeat_interval_secs It seems that the configuration controls this, but can it take effect immediately?

The configuration is static, must restart graphd server to make it take effect.

@jxnu-liguobin Thanks for your test tool, It will be a friendly and effective tool for users to make nebula related test. Could you please contribute your great test container to nebula-contrib? cc @QingZ11 @wey-gu

@wey-gu
Copy link
Contributor

wey-gu commented Oct 23, 2023

Wow, second project in a role!!!!🚀

nebula-contrib/testcontainers-nebula#2

@QingZ11 QingZ11 closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature req Type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants