Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry to get session when session is invalid in SessionPool (#252) #261

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

Sophie-Xie
Copy link
Contributor

No description provided.

* Update readme for v3.4 release (#250)

* Fix format

* Update README

* Retry to get session when session is invalid

* Simplify client test

* Add comments

* Add comments
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2023

Codecov Report

Patch coverage: 64.70% and project coverage change: -0.38 ⚠️

Comparison is base (18f0e65) 62.64% compared to head (36f51d1) 62.27%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
- Coverage   62.64%   62.27%   -0.38%     
==========================================
  Files           9        9              
  Lines        2230     2269      +39     
==========================================
+ Hits         1397     1413      +16     
- Misses        693      711      +18     
- Partials      140      145       +5     
Impacted Files Coverage Δ
session_pool.go 60.84% <53.84%> (-1.07%) ⬇️
configs.go 39.41% <100.00%> (+0.44%) ⬆️
session.go 47.69% <100.00%> (ø)
connection_pool.go 78.74% <0.00%> (-1.97%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants