Retry to get session when session is invalid in SessionPool
#252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aiee
force-pushed
the
reconnect-session
branch
from
8c88f81
to
5d69c43
Compare
|
we may need such retry mechanism in all clients :D |
HarrisChu
reviewed
Feb 9, 2023
HarrisChu
approved these changes
Feb 10, 2023
|
Can you merge this PR to master? We are still working on the http support for |
veezhang
reviewed
Feb 11, 2023
Comment on lines
+402
to
+403
| pool.rwLock.Lock() | ||
| defer pool.rwLock.Unlock() |
There was a problem hiding this comment.
Should it be possible to reduce the granularity of lock?
Only need to lock *list.List, not during session creation, execution, etc.
There was a problem hiding this comment.
Yeah, we should recheck the lock usage later.
Sophie-Xie
pushed a commit
that referenced
this pull request
Mar 3, 2023
* Update readme for v3.4 release (#250) * Fix format * Update README * Retry to get session when session is invalid * Simplify client test * Add comments * Add comments
Aiee
added a commit
that referenced
this pull request
Mar 3, 2023
…261) * Update readme for v3.4 release (#250) * Fix format * Update README * Retry to get session when session is invalid * Simplify client test * Add comments * Add comments Co-authored-by: Yichen Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Close #248
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc: