Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker image for arm64 #188

Closed
2 tasks done
wey-gu opened this issue Nov 16, 2022 · 2 comments · Fixed by #189
Closed
2 tasks done

docker image for arm64 #188

wey-gu opened this issue Nov 16, 2022 · 2 comments · Fixed by #189
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@wey-gu
Copy link
Contributor

wey-gu commented Nov 16, 2022 •
edited
Loading

  • in nightly build, it's not actully pushed as we are missing push: true for build-push-action@v3

nebula-console/.github/workflows/docker.yml

Lines 22 to 26 in c7012ff

- name: Build and push Docker images
uses: docker/build-push-action@v3
with:
platforms: linux/amd64,linux/arm64
tags: vesoft/nebula-console/nightly, vesoft/nebula-console/v3-nightly

  • the docker build and push in release.yaml is still the old one for single arch.

  • nightly image

  • release image
This was referenced Nov 19, 2022
Closed
Merged
@Sophie-Xie Sophie-Xie added the type/enhancement Type: make the code neat or more efficient label Nov 29, 2022
@Aiee Aiee closed this as completed in #189 Dec 1, 2022
@wey-gu
Copy link
Contributor Author

wey-gu commented Dec 1, 2022

Seems the docker build is failing, im debugging it locally now @Aiee @jievince

@wey-gu wey-gu reopened this Dec 1, 2022
This was referenced Dec 1, 2022
Merged
Merged
Merged
@wey-gu
Copy link
Contributor Author

wey-gu commented Dec 1, 2022

lQLPJxNkx5wtf6bNA27NBiqw5ZOhAzDYWCEDhMvZWUBpAA_1578_878

we now have nightly image in dual arch

@wey-gu wey-gu mentioned this issue Dec 1, 2022
Merged
7 tasks
@wey-gu wey-gu closed this as completed Dec 1, 2022
@wey-gu wey-gu mentioned this issue Dec 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Docker Push with arm64 vesoft-inc/nebula-console
2 participants
@wey-gu @Sophie-Xie