Skip to content

Commit fd179fa

Browse files
Ewan CrawfordreblejulianmiBensuo
authored
[SYCL][Graph] Throw an exception when unsupported features used in a graph (intel#10789)
This PR contains a set of changes that implement throwing an exception when a feature unsupported by [sycl_ext_oneapi_graph](https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_graph.asciidoc) is used. An error is thrown when an application uses the following features with the graph extension: * An unsupported extension. * Querying the event returned from graph submission for profiling information. * Level Zero immediate command-list (see intel#10467) * Specialization constants, kernel bundles, or reductions are used in a graph node. ## Authors Co-authored-by: Pablo Reble <[email protected]> Co-authored-by: Julian Miller <[email protected]> Co-authored-by: Ben Tracy <[email protected]> Co-authored-by: Ewan Crawford <[email protected]> Co-authored-by: Maxime France-Pillois <[email protected]>
1 parent dbb884b commit fd179fa

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

command_buffer.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -663,6 +663,12 @@ UR_APIEXPORT ur_result_t UR_APICALL urCommandBufferEnqueueExp(
663663
ur_exp_command_buffer_handle_t CommandBuffer, ur_queue_handle_t Queue,
664664
uint32_t NumEventsInWaitList, const ur_event_handle_t *EventWaitList,
665665
ur_event_handle_t *Event) {
666+
// There are issues with immediate command lists so return an error if the
667+
// queue is in that mode.
668+
if (Queue->UsingImmCmdLists) {
669+
return UR_RESULT_ERROR_INVALID_QUEUE_PROPERTIES;
670+
}
671+
666672
std::scoped_lock<ur_shared_mutex> lock(Queue->Mutex);
667673
// Use compute engine rather than copy engine
668674
const auto UseCopyEngine = false;

0 commit comments

Comments
 (0)