Skip to content

Extend StringAppendTESTOperator to use string delimiter of variable length #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Myasuka merged 1 commit into from
Oct 29, 2020
Merged

Extend StringAppendTESTOperator to use string delimiter of variable length #18

Myasuka merged 1 commit into from
Oct 29, 2020

Conversation

@Myasuka
Copy link
Contributor

@Myasuka Myasuka commented Oct 23, 2020

This PR is based on d215624 with some updates introduced by RocksDB-6.11.6

azagrebin
azagrebin approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@azagrebin azagrebin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this PR and fixing all the codestyle issues @Myasuka, LGTM
I also would suggest to squash the codestyle fixes into the main commit before merging

@Myasuka Myasuka force-pushed the frocksdb-cp-bug-fix-3 branch from 6bf03a5 to 179ee2a Compare October 27, 2020 04:21
@Myasuka Myasuka merged commit 67353d3 into ververica:FRocksDB-6.11.6 Oct 29, 2020
This was referenced Nov 6, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@azagrebin azagrebin azagrebin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Myasuka @azagrebin