From 7e0695f9d388c557c1bed43ca05899f1dddab400 Mon Sep 17 00:00:00 2001 From: Sebastian Sebbie Silbermann Date: Fri, 30 May 2025 12:02:09 +0200 Subject: [PATCH] [dev-overlay] Remove unnecessary code from /pages dev error boundary No longer needed in React 18+ --- .../pages/pages-dev-overlay-error-boundary.tsx | 4 ---- .../components/react-dev-overlay/pages/pages-dev-overlay.tsx | 4 +--- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay-error-boundary.tsx b/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay-error-boundary.tsx index 7117d00d47b8..3d61edcc2464 100644 --- a/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay-error-boundary.tsx +++ b/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay-error-boundary.tsx @@ -15,10 +15,6 @@ export class PagesDevOverlayErrorBoundary extends React.PureComponent< return { error } } - componentDidCatch(error: Error) { - this.setState({ error }) - } - // Explicit type is needed to avoid the generated `.d.ts` having a wide return type that could be specific to the `@types/react` version. render(): React.ReactNode { // The component has to be unmounted or else it would continue to error diff --git a/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay.tsx b/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay.tsx index 935f3cbf174d..f4fd8dde240d 100644 --- a/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay.tsx +++ b/packages/next/src/client/components/react-dev-overlay/pages/pages-dev-overlay.tsx @@ -17,9 +17,7 @@ export function PagesDevOverlay({ children }: PagesDevOverlayProps) { return ( <> - - {children ?? null} - + {children} {/* Fonts can only be loaded outside the Shadow DOM. */}