From 5d9ce703a12a1cbb8fb31313748fa3f057e64009 Mon Sep 17 00:00:00 2001 From: Tobias Koppers Date: Wed, 19 May 2021 11:15:45 +0200 Subject: [PATCH 1/2] server doesn't need to be contenthashing at all --- packages/next/build/webpack-config.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/next/build/webpack-config.ts b/packages/next/build/webpack-config.ts index 5a3a59975e6e3..e9023a198d261 100644 --- a/packages/next/build/webpack-config.ts +++ b/packages/next/build/webpack-config.ts @@ -825,7 +825,7 @@ export default async function getBaseWebpackConfig( splitChunks: isServer ? isWebpack5 ? ({ - filename: `${dev ? '[name]' : '[name].[contenthash]'}.js`, + filename: '[name].js', // allow to split entrypoints chunks: 'all', // size of files is not so relevant for server build @@ -931,7 +931,7 @@ export default async function getBaseWebpackConfig( : 'static/webpack/[hash].hot-update.json', // This saves chunks with the name given via `import()` chunkFilename: isServer - ? `${dev ? '[name]' : '[name].[contenthash]'}.js` + ? '[name].js' : `static/chunks/${isDevFallback ? 'fallback/' : ''}${ dev ? '[name]' : '[name].[contenthash]' }.js`, From 993c8f562a90b18482f95ed9051dc44ee027707e Mon Sep 17 00:00:00 2001 From: JJ Kasper Date: Wed, 19 May 2021 13:01:34 -0500 Subject: [PATCH 2/2] update size --- test/integration/build-output/test/index.test.js | 2 +- yarn.lock | 5 ----- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/test/integration/build-output/test/index.test.js b/test/integration/build-output/test/index.test.js index 7390a2dc4bcb7..b30153e3dfad0 100644 --- a/test/integration/build-output/test/index.test.js +++ b/test/integration/build-output/test/index.test.js @@ -129,7 +129,7 @@ describe('Build Output', () => { expect(parseFloat(err404Size)).toBeCloseTo(gz ? 3.06 : 8.15, 1) expect(err404Size.endsWith('kB')).toBe(true) - expect(parseFloat(err404FirstLoad)).toBeCloseTo(gz ? 66.5 : 203, 1) + expect(parseFloat(err404FirstLoad)).toBeCloseTo(gz ? 66.4 : 203, 1) expect(err404FirstLoad.endsWith('kB')).toBe(true) expect(parseFloat(sharedByAll)).toBeCloseTo(gz ? 63.4 : 195, 1) diff --git a/yarn.lock b/yarn.lock index 0be96bb5a737c..b02d797541fde 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2383,11 +2383,6 @@ call-me-maybe "^1.0.1" glob-to-regexp "^0.3.0" -"@next/eslint-plugin-next@^10.1.3": - version "10.1.3" - resolved "https://registry.yarnpkg.com/@next/eslint-plugin-next/-/eslint-plugin-next-10.1.3.tgz#739743aa33aed28d97e670b9f80b84440cf2a3c7" - integrity sha512-KrZUb6cHXt/rPhN9bSrlVLAq+9LyNOWurqbrUww3OXmrFlXBDI8W6Z0ToDkQMkIH6gTtmpGbuctxCkQ2pgeXzQ== - "@nodelib/fs.scandir@2.1.3": version "2.1.3" resolved "https://registry.yarnpkg.com/@nodelib/fs.scandir/-/fs.scandir-2.1.3.tgz#3a582bdb53804c6ba6d146579c46e52130cf4a3b"