Skip to content

Commit 739e0c3

Browse files
authored
Add test for serverExternalPackages inside node_modules (#68156)
Adds a test for the change in #67948
1 parent 2c8736a commit 739e0c3

File tree

8 files changed

+35
-1
lines changed

8 files changed

+35
-1
lines changed

test/e2e/app-dir/app-external/app-external.test.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -229,6 +229,11 @@ describe('app dir - external dependency', () => {
229229
const $ = await next.render$('/esm/react-namespace-import')
230230
expect($('#namespace-import-esm').text()).toBe('namespace-import:esm')
231231
})
232+
233+
it('should apply serverExternalPackages inside of node_modules', async () => {
234+
const html = await next.render('/transitive-external')
235+
expect(html).toContain('transitive loaded a')
236+
})
232237
})
233238

234239
describe('mixed syntax external modules', () => {
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import { load } from 'transitive'
2+
3+
export default async function Page() {
4+
let value = await load('a')
5+
return <d1iv>{value}</d1iv>
6+
}
Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
module.exports = {
22
reactStrictMode: true,
33
transpilePackages: ['css', 'font', 'transpile-ts-lib', 'transpile-cjs-lib'],
4-
serverExternalPackages: ['conditional-exports-optout', 'dual-pkg-optout'],
4+
serverExternalPackages: [
5+
'conditional-exports-optout',
6+
'dual-pkg-optout',
7+
'transitive-external',
8+
],
59
}

test/e2e/app-dir/app-external/node_modules/transitive-external/a.mjs

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/e2e/app-dir/app-external/node_modules/transitive-external/index.mjs

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/e2e/app-dir/app-external/node_modules/transitive-external/package.json

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/e2e/app-dir/app-external/node_modules/transitive/index.mjs

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/e2e/app-dir/app-external/node_modules/transitive/package.json

Lines changed: 4 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)